Fix deprecation warnings and improve property handling#63
Closed
Mallon94 wants to merge 2 commits into
Closed
Conversation
- Explicitly declare the `$ipinfo` and `$no_except` properties to avoid dynamic creation which is deprecated as of PHP 8.2. - Update the docblock for the `$filter` property to accurately represent its type as `callable`. - Ensure that all class properties are initialized properly to prevent runtime errors and adhere to stricter PHP standards.
all illuminate/support 11
Contributor
|
Hello @Mallon94 , I'm picking up our Laravel library again and just found out about your PR. Sorry for the lack of response! I've just released v2.7.0 with Laravel v11 support. Could you rebase and send me your PR with the latest changes? |
Contributor
|
Superseded by #77. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ipinfoand$no_exceptproperties to avoid dynamic creation which is deprecated as of PHP 8.2.$filterproperty to accurately represent its type ascallable.